fix(tabs): announce the active tab to VoiceOver on tab switch (#1490)#1508
Merged
Conversation
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1490 (keyboard, focus, accessibility). Tabs & windows surface.
Most of this surface's critical gaps (filter Apply focus return, Apply
.defaultAction, filter button labels) already landed in #1492. The remaining clean win is the VoiceOver gap:windowDidBecomeKey(a native window-tab switch), post an.announcementRequestedaccessibility notification with the active tab's title, so VoiceOver users get the same context the window title gives sighted users. Posted unconditionally (the system delivers it only to running assistive tech).Native
NSAccessibility.post, no behavior change for non-VoiceOver users.Deferred (uncertain / larger): explicit first-responder restore on tab switch (AppKit's
NSWindowalready restores its first responder), andrecalculateKeyViewLoopwiring, which belongs with the Tab-between-panes work.Lint clean, style gate clean.